Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications don't work #683

Closed
sharkwouter opened this issue Oct 2, 2019 · 10 comments
Closed

Notifications don't work #683

sharkwouter opened this issue Oct 2, 2019 · 10 comments

Comments

@sharkwouter
Copy link
Contributor

sharkwouter commented Oct 2, 2019 •
edited

Notifications haven't worked for me for a while now, but I didn't find a bug report about it yet. There is a thread on Reddit about it from a while back: https://www.reddit.com/r/RedReader/comments/ai1b8v/i_dont_get_notifications_i_used_to_but_not_now/

I'm using a Nokia 8 Plus with Android 9, in case that helps.
@japanesephundroid
Copy link

japanesephundroid commented Oct 2, 2019 •
edited

I get this as well since upgrading to Oreo.
This is an Oreo (Android 8 and after) bug as far as I can tell.

You can see the exact error if you go into Developer Options and enable Show notification channel warnings.

The error you will get is this:

Developer warning for package
"org.quantumbadger.redreader"
Failed to post notification on channel "null"
See log for more details

The error seems to be related to the Notification channels Android feature introduced on Android 8.

@QuantumBadger
Copy link
Owner

Thanks @japanesephundroid, it's a shame this just silently fails by default! Sounds like it should be a relatively simple fix though.

@japanesephundroid
Copy link

Thanks @japanesephundroid, it's a shame this just silently fails by default! Sounds like it should be a relatively simple fix though.

No problem, it's probably no coincidence Google added added that option in the developer options, they expected this to happen but didn't want that message popping up to regular users.

I've seen this happen on a few other apps as well, it even happened with an app that has support for notification channels, probably some old function forgotten somewhere in the code.

@QuantumBadger
Copy link
Owner

Should be fixed in Alpha 181 -- please let me know if so!

https://redreader.org/alpha/

@japanesephundroid
Copy link

japanesephundroid commented Oct 4, 2019 •
edited

I just made a self post on the subreddit.

https://www.reddit.com/r/RedReader/comments/dd97y0/testing_notifications_fix_for_oreo_and_later_on/

When you or someone else replies there I will tell you if it works.

@sharkwouter
Copy link
Contributor Author

I've replied to it. Does it work?

@QuantumBadger
Copy link
Owner

The app checks for new messages every 30 mins, so it might take a while for the notification to appear.

@japanesephundroid
Copy link

I've replied to it. Does it work?

Not yet, QuantumBadger says to wait for 30 minutes so stay tuned. I gonna reply to you to test that notification.

@japanesephundroid
Copy link

Just got it now 👍

@QuantumBadger
Copy link
Owner

Thanks both :)

MichalFerencsik added a commit to MichalFerencsik/RedReader that referenced this issue Nov 26, 2019
@MichalFerencsik
Wip/tests (#1)
77c1d28 
* Save v.redd.it videos as mp4 when downloading (QuantumBadger#681)

* Save v.redd.it videos as mp4 when downloading

I'm not sure if this is the best approach here, but this does fix QuantumBadger#639

* Used getHost on the URI instead of contains on a string

* Removed unused import
The PMD check failed because of it.

* use uri variable instead of uriFromString

* Updating changelog

* Update string.xml (QuantumBadger#665)

* Update string.xml

Fix wrong FR translation

* Update string.xml

* Fix "Skip to Frontpage" disregarding two-panel option (QuantumBadger#684)

* Updating changelog QuantumBadger#665

* Updating changelog (QuantumBadger#684)

* Fixed notifications on Android 8.0+ (fixes QuantumBadger#683)

* Adaptive icon (QuantumBadger#675)

* Move .png icons to mipmap where they belong

* Add adaptive icon

* Add GPL comments to adaptive icon files

* Updated changelog (QuantumBadger#675)

* Initial attempt at adaptive alpha icon (QuantumBadger#675)

* Move alpha png icons to mipmap (QuantumBadger#675)

* Issue#637: Implement copy to clip body of post (QuantumBadger#682)

* Implement post text copy

* Put string to strings.xml and CZ loc

* repair string macro

* repair string translate

* Updated

* Updated

* Updated

* revert bug

* Updated changelog (QuantumBadger#637)

* tests implementation

* tests beggining

* Create config.yml

* Update config.yml

* Update config.yml

* add licence for sake of circleCI

* Update CircleCI config

* Update CircleCI config

* Update CircleCI config

* Update CircleCI config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@QuantumBadger @sharkwouter @japanesephundroid