Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove date range limitation #100

Closed
basings opened this issue Jun 4, 2024 · 4 comments
Closed

remove date range limitation #100

basings opened this issue Jun 4, 2024 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@basings
Copy link

basings commented Jun 4, 2024

Is your feature request related to a problem? Please describe.
Adding data prior to 21 is not possible.

Describe the solution you'd like
A clear and concise description of what you want to happen.
No artificial limitation

Describe alternatives you've considered
Using openscale.

@basings basings added the enhancement New feature or request label Jun 4, 2024
@braniii
Copy link
Contributor

braniii commented Jun 4, 2024

Hi @basings thank you for your suggestion. The input restriction only applies to manual entries. It should (hopefully!) work when importing the measured values. Initially we've added this limitations because the computational time of the interpolation scales with the overall timespan. So adding a single old measurement, e.g. 2 years in the past, the performance was really bad. With the rewrite of the computation in v0.6.0 this should be less effected.

@gwosd What do you think of simply removing this limitation?

@basings
Copy link
Author

basings commented Jun 4, 2024

Thank you for your quick response. Now it makes sense why there was a limitation in the first place. I assume you switched to a rolling window now which would make the limitation obsolte.

I wasn't able to import my multi year entries from openScale, although I respected the space limited file structure as the export suggested. I tried adding the entries manually after that.

@gwosd
Copy link
Contributor

gwosd commented Jun 7, 2024

@braniii Sounds like a good plan.

@basings Thank you for reporting the limitation

@braniii
Copy link
Contributor

braniii commented Jul 1, 2024

@basings I've adjusted the code so that you can add dates starting from 1970 (starting of the epoch in dart language). However, I couldn't reproduce the issue with adding backups older than 2 years. In case you are still facing issues with importing backups, please reopen this issue.

@braniii braniii closed this as completed Jul 1, 2024
braniii added a commit that referenced this issue Jul 1, 2024
Increase first possible date to maximum of dart epoche (1970), #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants