-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context menu to documents tabs #708
Conversation
What about an option to "Open file location in File browser" or something like that. |
yes, an "Open file location in File browser" will make sense (also in the Project View), I also do need to copy stuff from a project directory from time to time. And BTW, I also have multiple "Qucs home" locations and find frustrating that I cannot navigate these within the Project View, but this latter will be for (much) later. Coming back to this PR, the cleanup I mentioned above was about some code duplication I think there is in |
Just a suggestion for improvement: I really like to put the diagrams in the schematic sheet, so more often than not I deactivate the option "Open data display after simulation" under the "File->Document Settings" menu. Would it make sense to add this option to the tab context menu? |
um, I also do this relatively often but I don't think that enabling/disabling "Open data display after simulation" should go in a context menu about opening/closing Tabs/Documents. Since this choice is usually done at file creation it should be selectable there; I think we discussed in the past having Schematics templates, so under the menu File we could have New, New w/o Data Display and New from template or something like that (keeping the current keyboard shortcuts). |
188d1f8
to
6a93da5
Compare
allowing to close the tab, close all the other tabs and close all tabs.
and for opening a schematic folder in a file browser.
so they will easier to discover
only for already-saved documents.
6a93da5
to
da743ff
Compare
I've added "Open containing folder", "Copy full path" and other items to the tab context menu. |
Thank you 👍 I haven't tested the latest commit yet... but what about having a shortcut for creating a new stand-alone schematic (maybe shift+N)? |
yep, I was not sure if I should add shortcuts for all the new stuff but I too thought of adding the a shortcut for the stand-alone schematic. I think Ctrl-Shift-N might be more in line with the other menu shortcuts, all start with Ctrl and Shift is sometimes a modifier to the Ctrl- action. |
I agree. This reminds me that #558 is still there. I'll be back with it after 0.0.20 😁 |
I've added a shortcut for creating a new stand-alone schematic but Ctrl+Shift+N was already used by the "New Project" action, so I used Ctrl+Shift+H since it seemed one of the few not-already-in-use shortcuts. |
I've done a quick check and I didn't find issues. Things I've checked:
I've also taken a look at the last commit. It looks good 👍 |
since I sometimes open a lot of tabs, e.g. while looking for a particular schematic/feature, I needed a convenient way of closing all the tabs currently open except the one of interest.
I've then added a context menu to the tabs, like this
I've also added a Close all action and, why not, a simple Close for the current tab.
Works fine here, I do not actually plan big modifications to the code, just maybe a little cleanup to
qucs.cpp
.