Skip to content

react-experiment: no logger flush #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2023
Merged

react-experiment: no logger flush #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83b8b0c
react-experiment: do not depend on logger's flush
QuentinRoy May 19, 2023
9c8db5e
changeset
QuentinRoy May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-tools-grow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@lightmill/react-experiment': major
---

Do not flush before completing a run, and do not require loggers to define a flush method.
2 changes: 0 additions & 2 deletions packages/react-experiment/src/timeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ type TimelineAction<T> =
export type Logger = {
startRun(): Promise<void>;
addLog(log: RegisteredLog): Promise<void>;
flush(): Promise<void>;
completeRun(): Promise<void>;
cancelRun?(): Promise<void>;
};
Expand Down Expand Up @@ -117,7 +116,6 @@ export default function useManagedTimeline<Task extends BaseTask>(
});
if (hasEnded) return;
dispatch({ type: 'all-tasks-completed' });
await logger?.flush();
await logger?.completeRun();
if (hasEnded) return;
dispatch({ type: 'run-completed' });
Expand Down