Reorganized Nimble source structure. Fixes #267 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: Cocoapods podspec wrongly included a Linux-only swift file. Added exclude_files to cocoapod podspec. This commit also reorganizes the structure of Nimble to avoid future errors and simplify the groups a bit: - Objective-C specific code is now in Sources/Nimble/Adapters/ObjectiveC - Non-Objective-C specific code is now in Sources/Nimble/Adapters/NonObjectiveC - This is code that Xcode should **ignore** - Rename `ObjC` prefixed files to `NMB` - Move files in `Wrapper` to `Matchers`
|
👍 thanks for fixing this up @jeffh! |
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Reorganized Nimble source structure. Fixes Quick#267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Cocoapods podspec wrongly included a Linux-only swift file. Added
exclude_files to cocoapod podspec.
This commit also reorganizes the structure of Nimble to avoid future
errors and simplify the groups a bit:
ObjCprefixed files toNMBWrappertoMatchers