Add swift version check for default runloop case name #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongzigii
approved these changes
Jun 23, 2018
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Add swift version check for default runloop case name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I was playing with
Nimbleon Swift 4.2 and there was only one change needed for my scheme to compile: name change fordefaultrunloop.Note: I was trying to find in the codebase how (or if) do you guys handle backwards compatibility, but couldn't find anything after dropping the support of Swift 3. I've made a single
#ifdirective, but I'm happy to update the PR with any given guidelines for these kinds of PRs.