-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intellij-style, side-locked dockers and ui cleanup #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix0rai
changed the title
intellij-style, side-locked dockers
intellij-style, side-locked dockers and ui cleanup
Jan 15, 2023
IotaBread
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issues I could find now
-
Dock resizing doesn't work unless you minimize the resized docker before changing to a new one, within the same dock
-
In some cases, dock sizing may become inconsistent
Reproduction steps:
- Launch Enigma
- Open a docker the left and right
- Minimize all dockers on the right
- Minimize all dockers on the left
- Open a docker on the right
- It's width is now different from the previous one
This reverts commit 073a2fa.
This was referenced Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about ready for testing, so I'm drafting this here!
changelog:
--single-class-tree
option for viewing both deobf and obf classes in one paneltodo
--single-classes-panel
command line optionnotes:
builds off #23 and is a quilt equivalent of FabricMC/Enigma#420
fixes #25
this could be a good opportunity to introduce a "partially deobfuscated classes" docker, similar to FabricMC/Enigma#482, although I'd prefer to do that in a separate PR