Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intellij-style, side-locked dockers and ui cleanup #28

Merged
merged 67 commits into from
Jan 23, 2023

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Jan 14, 2023

about ready for testing, so I'm drafting this here!

changelog:

  • dockers!
    • dragged around via their title
    • can be docked in 6 different locations
    • 4 dockers can be on the screen at once (+1 from previous maximum amount of visible side panels!)
    • minimise button to close
    • docks will highlight the future location of the docker when hovered while dragging a docker label
  • new panel: all classes
    • replaces the old --single-class-tree option for viewing both deobf and obf classes in one panel
  • add "start server" and "connect to server" buttons to collab panel when offline, for convenience
  • remove a bunch of dead code
  • cleanup and style enforcement

todo

  • testing and bugfixing
  • closing docker panels when empty
  • improving intuitiveness of moving things around
  • translation migrations
  • make it more obvious that docker titles are what you should drag to move panels
  • configurable highlight colour
  • add "all classes" docker
  • reimplement --single-classes-panel command line option
  • custom hover and drag cursors for draggable labels

notes:
builds off #23 and is a quilt equivalent of FabricMC/Enigma#420
fixes #25
this could be a good opportunity to introduce a "partially deobfuscated classes" docker, similar to FabricMC/Enigma#482, although I'd prefer to do that in a separate PR

@ix0rai ix0rai self-assigned this Jan 14, 2023
@ix0rai ix0rai added the enhancement New feature or request label Jan 14, 2023
@ix0rai ix0rai changed the title intellij-style, side-locked dockers intellij-style, side-locked dockers and ui cleanup Jan 15, 2023
@ix0rai ix0rai requested a review from IotaBread January 18, 2023 02:34
Copy link
Member

@IotaBread IotaBread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issues I could find now

  • Dock resizing doesn't work unless you minimize the resized docker before changing to a new one, within the same dock

  • In some cases, dock sizing may become inconsistent

    Reproduction steps:

    1. Launch Enigma
    2. Open a docker the left and right
    3. Minimize all dockers on the right
    4. Minimize all dockers on the left
    5. Open a docker on the right
    6. It's width is now different from the previous one

@ix0rai ix0rai requested a review from IotaBread January 19, 2023 00:55
@ix0rai ix0rai merged commit f3ed8f0 into QuiltMC:master Jan 23, 2023
@ix0rai ix0rai deleted the dockers-3 branch January 25, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] add intellij-style dockers
3 participants