add improved side panel selector and clean up gui by ix0rai · Pull Request #23 · QuiltMC/enigma

ix0rai · 2022-12-29T02:37:16Z

this pr implements a better selector for side panels and improves a lot of gui code
inspired by, and steals code from, FabricMC/Enigma#420

changelog (incomplete):

add side panel selector
add translation for "send message" button in multiplayer chat

todo:

bug: structure panel flashes for a second when a new class is opened
bug: panels often forget their states when hiding and showing
bug: pressed side button does not always perfectly reflect selected side panel
feature: add little "enigma is offline" message to multiplayer windows when enigma is offline
feature: consistent text box size in "users" panel
feature: make it less ugly
feature: title bar above each panel to indicate what's open
change: make the whole registration system more robust
change: find a better solution than saiko's insane jlayer rotation code

…erent-side-panels # Conflicts: # enigma-swing/src/main/java/cuchaz/enigma/gui/panels/StructurePanel.java # enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/AbstractInheritanceTree.java

IotaBread

Did a quick review, gonna check everything once the pr is done

enigma-swing/src/main/java/cuchaz/enigma/gui/config/UiConfig.java

enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/AbstractInheritanceTree.java

enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/RightRotatedLayerUI.java

… enigma is offline

- fix flashing structure panel - fix calls panel opening with classes - configure right panel on opening

…nges from server

IotaBread

Just nitpicking

enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/RightPanel.java

enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/StructurePanel.java

enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/RightAngleLayerUI.java

enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/MultiplayerPanel.java

IotaBread

Great job! I'll do some testing and it should be good to go

ix0rai · 2023-01-06T02:00:55Z

definitely not kicking my feet excitedly right now

ix0rai added 13 commits December 27, 2022 20:37

initial right panel selector implementation

a8e8478

initial right panel selector implementation

9c26816

Merge remote-tracking branch 'origin/different-side-panels' into diff…

c6a4ab7

…erent-side-panels # Conflicts: # enigma-swing/src/main/java/cuchaz/enigma/gui/panels/StructurePanel.java # enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/AbstractInheritanceTree.java

fix build

fa946c1

fix weird thing

df7edb8

implement panel opening and closing

8dd93e2

add toggle buttons

4156adb

remove hack2

9308758

cleanup

1b9bdcc

gui cleanup

be6f48b

reimplement multiplayer panels

416e62e

cleanup and save selected right panel

414a141

translations and cleanup

6d4fa9b

ix0rai added the enhancement new feature or request label Dec 29, 2022

ix0rai added 2 commits December 28, 2022 21:00

fix button jankiness

87ccc1c

move entire button declaration to AbstractRightPanel

7b54895

IotaBread reviewed Dec 29, 2022

View reviewed changes

enigma-swing/src/main/java/cuchaz/enigma/gui/config/UiConfig.java Outdated Show resolved Hide resolved

enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/AbstractInheritanceTree.java Outdated Show resolved Hide resolved

OroArmor approved these changes Dec 29, 2022

View reviewed changes

dblsaiko reviewed Dec 29, 2022

View reviewed changes

enigma-swing/src/main/java/cuchaz/enigma/gui/panels/right/RightRotatedLayerUI.java Outdated Show resolved Hide resolved

ix0rai added 7 commits December 29, 2022 16:59

add "enigma is offline" message to multiplayer-only right panels when…

1b82368

… enigma is offline

revert bad changes

11f6dc8

make messing up the button state impossible (in theory)

817f3ea

move right panels entirely into an abstract class

62486de

Merge branch 'QuiltMC:master' into different-side-panels

4514c11

save divider location per-right-panel

eb217a0

add title bars; cleanup

4a39d2a

ix0rai mentioned this pull request Dec 30, 2022

[feature request] add intellij-style dockers #25

Closed

ix0rai added 3 commits December 29, 2022 21:38

fixes

2e1cc5b

- fix flashing structure panel - fix calls panel opening with classes - configure right panel on opening

better consistency in UsersPanel

53e34ae

Merge branch 'QuiltMC:master' into different-side-panels

3a84fe8

ix0rai added 13 commits January 1, 2023 22:01

merge multiplayer panels

262c19d

add generic getPanel()

ba82826

throw exception when missing right panel is requested

d9c57c4

fix panel order

cb8e598

move updateStateIfCurrent check to avoid running else block if false

68bda98

better validation

7362553

fix bug discovered by @bymartrixx

a044610

add updateStructure(), do not show structure panel when receiving cha…

bd36e63

…nges from server

documentation and rename

f6bde08

fix dead link

a6d06eb

new translations

92029d4

fix translation file indentation

bb23f42

actually fix indentation, migrate existing translations

0fb4240

ix0rai requested a review from IotaBread January 3, 2023 21:23

remove debug logging

0c901b7

IotaBread reviewed Jan 4, 2023

View reviewed changes

ix0rai added 2 commits January 4, 2023 18:58

FINAL indent fixing

3abc168

rename multiplayer panel to collab panel

420c8fe

ix0rai requested a review from IotaBread January 5, 2023 01:00

ix0rai added 3 commits January 4, 2023 19:04

npe fix from @bymartrixx

e549627

sometimes ctrl + f isn't enough

6819b6f

use correct order in right panels

cde64b6

IotaBread approved these changes Jan 6, 2023

View reviewed changes

ix0rai added 3 commits January 5, 2023 20:15

fix crash with invalid right panel id

9723b02

fix visual corruption on buttons when switching panels through keybinds

fd4d563

ACTUALLY fix right panel button ordering

d731356

IotaBread merged commit eb15b89 into QuiltMC:master Jan 6, 2023

ix0rai deleted the different-side-panels branch January 6, 2023 03:49

ix0rai mentioned this pull request Jan 14, 2023

intellij-style, side-locked dockers and ui cleanup #28

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add improved side panel selector and clean up gui#23

add improved side panel selector and clean up gui#23
IotaBread merged 53 commits intoQuiltMC:masterfrom
ix0rai:different-side-panels

ix0rai commented Dec 29, 2022 •

edited

Loading

Uh oh!

IotaBread left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IotaBread left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IotaBread left a comment

Uh oh!

ix0rai commented Jan 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ix0rai commented Dec 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IotaBread left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IotaBread left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IotaBread left a comment

Choose a reason for hiding this comment

Uh oh!

ix0rai commented Jan 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ix0rai commented Dec 29, 2022 •

edited

Loading