Skip to content

Commit

Permalink
fix: Yarn 3/4 PnP compatibility (#5042)
Browse files Browse the repository at this point in the history
* CI

* revert

---------

Co-authored-by: Roman Zanettin <roman.zanettin@gmail.com>
  • Loading branch information
ianlet and zanettin authored Oct 31, 2023
1 parent 0ebe02c commit f8b68c9
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 19 deletions.
3 changes: 2 additions & 1 deletion packages/qwik-city/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
"@types/mdx": "^2.0.8",
"source-map": "0.7.4",
"svgo": "^3.0.2",
"undici": "^5.26.0",
"vfile": "^6.0.1",
"vite": "^4.4.11",
"vite-imagetools": "^5.0.9",
"zod": "^3.22.4"
},
Expand Down Expand Up @@ -39,7 +41,6 @@
"unified": "10.1.2",
"unist-util-visit": "5.0.0",
"uvu": "0.5.6",
"vite": "^4.4.11",
"yaml": "^2.3.2"
},
"engines": {
Expand Down
3 changes: 2 additions & 1 deletion packages/qwik/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
}
],
"dependencies": {
"csstype": "^3.1.2"
"csstype": "^3.1.2",
"vite": "^4.4.11"
},
"devDependencies": {
"@builder.io/qwik-dom": "workspace:*",
Expand Down
25 changes: 9 additions & 16 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion scripts/validate-build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export async function validateBuild(config: BuildConfig) {
const pkgFiles = [...pkg.files!, 'LICENSE', 'README.md', 'package.json'];
const expectedFiles = pkgFiles.map((f) => join(config.distQwikPkgDir, f));

const dependencies = ['csstype'];
const dependencies = ['csstype', 'vite'];
const pkgDependencies = Object.keys(pkg.dependencies!);
if (pkgDependencies.length !== dependencies.length) {
errors.push(
Expand Down

0 comments on commit f8b68c9

Please sign in to comment.