Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐞] Support for typescript suggestions in style properties of tags. #4059

Closed
adiathasan opened this issue May 4, 2023 · 0 comments
Closed

[🐞] Support for typescript suggestions in style properties of tags. #4059

adiathasan opened this issue May 4, 2023 · 0 comments
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working

Comments

@adiathasan
Copy link

adiathasan commented May 4, 2023 •
edited
Loading

Which component is affected?

Qwik Runtime

Describe the bug

This is not a bug. ⚔️

Support for typescript suggestions in style properties of tags. Not good at memorizing the props.

Currently Record<string | ....> isn't helping much

(property) HTMLAttributes<HTMLDivElement>.style?: string | Record<string, string | number | undefined> | undefined

Steps to reproduce

Just command+space suggestions not showing!!!
@adiathasan adiathasan added TYPE: bug Something isn't working STATUS-1: needs triage New issue which needs to be triaged labels May 4, 2023
hbendev added a commit to hbendev/qwik that referenced this issue Jun 23, 2023
@hbendev
fix(qwik-core): add types for the style attribute
343eb44 
Adds csstype as a devdependency, and changes the TS types. This adds autocomplete options, while
still allowing all previously supported syntaxes, like 'padding-top' and '--var' in the style
objects.

Improvement asked in QwikDev#4059
hbendev added a commit to hbendev/qwik that referenced this issue Jun 23, 2023
@hbendev
fix(qwik-core): add types for the style attribute
bfebf93 
Adds csstype as a devdependency, and changes the TS types. This adds autocomplete options, while
still allowing all previously supported syntaxes, like 'padding-top' and '--var' in the style
objects.

Improvement asked in QwikDev#4059
hbendev added a commit to hbendev/qwik that referenced this issue Jun 23, 2023
@hbendev
fix(qwik-core): add types for the style attribute
bd9ff40 
Adds csstype as a devdependency, and changes the TS types. This adds autocomplete options, while
still allowing all previously supported syntaxes, like 'padding-top' and '--var' in the style
objects.

Improvement asked in QwikDev#4059
@hbendev hbendev mentioned this issue Jun 23, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adiathasan