Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐞] Internal assert when SSR rendering <Link> inside a <div> container #4618

Closed
omarbelkhodja opened this issue Jun 26, 2023 · 2 comments · Fixed by #4623
Closed

[🐞] Internal assert when SSR rendering <Link> inside a <div> container #4618

omarbelkhodja opened this issue Jun 26, 2023 · 2 comments · Fixed by #4623
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working

Comments

@omarbelkhodja
Copy link

Which component is affected?

Qwik Runtime

Describe the bug

When rendering a <Link> element inside a <div> container, the following error occurs when clicking on the link :
Error: Internal assert, this is likely caused by a bug in Qwik: close not found

Reproduction

https://stackblitz.com/edit/qwik-starter-jg6cng?file=src%2Froutes%2Findex.tsx

Steps to reproduce

  1. Open the devtools console
  2. Click on the 'Flower App' link
  3. Assert will trigger

System Info

I'm on Windows and using Chrome

Additional Information

No response
@omarbelkhodja omarbelkhodja added TYPE: bug Something isn't working STATUS-1: needs triage New issue which needs to be triaged labels Jun 26, 2023
@stackblitz
Copy link

stackblitz bot commented Jun 26, 2023

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@manucorporat
Copy link
Contributor

The issue is caused by:

    containerTagName: 'div',

in entry.ssr.tsx

it's making a <div> element as the root container then, rendering a <head> inside, this goes against the html spec and everything falls apart.

The error message indeed is not helpful and i will work to add another error that early detects this!

In the meantime, remove the containerTagName: 'div', config!

manucorporat added a commit that referenced this issue Jun 27, 2023
@manucorporat
fix: detect invalid html
b687cdd 
fixes #4618
@manucorporat manucorporat mentioned this issue Jun 27, 2023
Merged
manucorporat added a commit that referenced this issue Jun 27, 2023
@manucorporat
fix: detect invalid html (#4623)
9041ae1 
fixes #4618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: detect invalid html QwikDev/qwik
2 participants
@manucorporat @omarbelkhodja