Vendor yarn executable #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-rustup users have to run this.
mandx
approved these changes
Jan 11, 2022
| @@ -0,0 +1 @@ | |||
| yarnPath: .yarn/releases/yarn-1.23.0-20211220.1904.cjs | |||
There was a problem hiding this comment.
Apologies for the dumb question, but anyways: This means one needs to have yarn installed globally, then that yarn executable will look at that this file, read the yarnPath key, and just execute (or shell out to) this binary instead, and nothing more?
If this is correct, then devs (and CI I guess) would just install any Yarn version (assuming all versions have the same behavior of reading .yarnrc.yml and reading yarnPath from it)?
There was a problem hiding this comment.
yes I believe that is accurate
mhevery
approved these changes
Jan 12, 2022
This was referenced Jan 25, 2022
This was referenced Feb 4, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a vendored copy of the yarn executable to version control as well as a
config file (.yarnrc.yml) to instruct clients which version to use.
Purpose of this is to ensure that everyone uses the same version, leading to
reproducible builds - and ensures that the project builds properly when mounted
as a submodule of a directory that also has a yarn lock file. In effect this
ensures that this project is built with yarn 1 and treated as it's own root.
Changelog