Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(qwik): add css properties to jsx html attributes #3209

Closed
wants to merge 1 commit into from
Closed

refactor(qwik): add css properties to jsx html attributes #3209

wants to merge 1 commit into from

Conversation

huijiewei
Copy link

@huijiewei huijiewei commented Mar 1, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

add css properties to jsx html attributes.

Use cases and why

none

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@stackblitz
Copy link

stackblitz bot commented Mar 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@manucorporat
Copy link
Contributor

Adding a new dependency is not an easy decision for us, happy to add this functionality, but i would like to avoid the extra dependency

@huijiewei
Copy link
Author

huijiewei commented Mar 1, 2023

Adding a new dependency is not an easy decision for us, happy to add this functionality, but i would like to avoid the extra dependency

css-type only typescript type define.

import type * as csstype from 'csstype';

dist will drop all.

only for best ide autocomplete!

thanks!

@zanettin zanettin added the COMP: DX Developer Experience related issue label Mar 1, 2023
@zanettin zanettin added the WAITING FOR: team Waiting for one of the core team members to review and reply label Aug 26, 2023
@gioboa
Copy link
Member

gioboa commented Oct 10, 2023

@huijiewei thanks for your help. csstype is a dependency in our codebase right now. The PR is old and there are few conflicts to solve, the best way to proceed is to create a new fresh PR with the latest codebase.
Are you still interested in it?

@mhevery
Copy link
Contributor

mhevery commented Oct 11, 2023

Thank you for your contribution. I am going to close this as a similar PR #4577 has already landed and has added this dependency.

@mhevery mhevery closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: DX Developer Experience related issue WAITING FOR: team Waiting for one of the core team members to review and reply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants