starters: Ensure that VSCode emmet uses JSX syntax for self-closing tags #5116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for qwik-insights canceled.
|
|
I suppose it's not as simple since apparently just |
colelawrence
changed the title
colelawrence
force-pushed
the
colelawrence-fix-starter-template-emmet
branch
from
3c5377a
to
c80bc5c
Compare
mhevery
approved these changes
Sep 6, 2023
is this ready for merge? |
|
@mhevery yes, I would like someone to run prettier on it really quick to fix CI, but I already addressed this comment and force pushed. |
kodiakhq bot
pushed a commit
to ascorbic/unpic-img
that referenced
this pull request
Sep 17, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik)) | [`1.2.10` -> `1.2.11`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.10/1.2.11) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@​builder.io/qwik)</summary> ### [`v1.2.11`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.2.11) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.10...v1.2.11) ##### What's Changed - Add useId() docs and demo component by [@​n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5037 - add n8sabes to contributors by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5040 - chore: array index can be typed as number by [@​wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#4748 - Modular Forms: Fix incorrect type in example by [@​RaeesBhatti](https://togithub.com/RaeesBhatti) in [QwikDev/qwik#5036 - docs: add docs about server$ middleware by [@​RaeesBhatti](https://togithub.com/RaeesBhatti) in [QwikDev/qwik#5033 - feat: add jsx-a eslint rule by [@​kerbelp](https://togithub.com/kerbelp) in [QwikDev/qwik#4256 - docs: Adding Example for useOnWindow by [@​josemartinez111](https://togithub.com/josemartinez111) in [QwikDev/qwik#4878 - chore: supabase-auth-helpers-qwik: update devDependencies by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5041 - fix: action type by [@​wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5034 - chore: add more debug info to build by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5047 - fix: align `function` and `()=>` behavior for JSX transpilation by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5012 - fix(core): correctly handle serialization of Signal of X and naked X by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5013 - fix(core): pass through decorators by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5052 - fix(qwik-city): correct rest route regression by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5054 - fix: QwikInsights path resolution by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5051 - docs: add qwikInsights vite plugin by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5055 - docs: change [@​builder](https://togithub.com/builder).io/qwik-labs version by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5057 - docs: add prettier as devDependencies ([#​5059](https://togithub.com/BuilderIO/qwik/issues/5059)) by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5061 - chore: fix .nvmrc with the right version by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5060 - docs: Document Relative URLs in Loaders by [@​n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5063 - docs: Cookbook recipe for playing audio and video media on iOS devices by [@​n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5066 - Revert "docs: Cookbook recipe for playing audio and video media on iOS devices" by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5073 - fix(qwik-city): do not write into a closed stream by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5074 - fix: loader type by [@​wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5062 - Add media controller to cookbook by [@​n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5078 - Fix the loader document by [@​n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5077 - feat: i18n $localize starter by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5070 - Loader doc consistency by [@​n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5082 - Enhance Media Controller Cookbook Recipe and fix fluid layout for smaller screens by [@​n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5081 - Remove overlooked console.log() from cookbook recipe by [@​n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5083 - Update cookbook to stream 1080p video content by [@​n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5084 - Update pages.json by [@​blove](https://togithub.com/blove) in [QwikDev/qwik#5085 - fix: library starter don't bundle dependencies by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#2008 - Fixed typo in Docs > Integrations > Prisma by [@​adcar](https://togithub.com/adcar) in [QwikDev/qwik#5090 - starter: Update deps and code of supabase auth helpers qwik pkg by [@​diecodev](https://togithub.com/diecodev) in [QwikDev/qwik#4745 - docs: Image updates - Qwik City by [@​hamatoyogi](https://togithub.com/hamatoyogi) in [QwikDev/qwik#5098 - docs: update the basic projection tutorial by [@​wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5093 - docs: update the implicit reactivity tutorial by [@​wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5092 - docs: remove outdated props store tutorial by [@​wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5095 - fix: remove missing tutorial ([#​5105](https://togithub.com/BuilderIO/qwik/issues/5105)) by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5106 - docs: fix "Endpoints" link on Qwik City -> Routing page by [@​jakovljevic-mladen](https://togithub.com/jakovljevic-mladen) in [QwikDev/qwik#5107 - chore: release qwik-auth 0.1.1 by [@​ulic75](https://togithub.com/ulic75) in [QwikDev/qwik#5103 - docs: update reactivity's counter example by [@​wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5091 - chore(eslint-plugin-qwik): change eslint to ^8.45 by [@​adaliszk](https://togithub.com/adaliszk) in [QwikDev/qwik#5110 - docs: fix mismatch title for implicit reactivity tutorial by [@​wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5111 - feat(optimizer): add qwikVite configuration option optimizerOptions.inlineStylesUpToBytes by [@​jaroel](https://togithub.com/jaroel) in [QwikDev/qwik#5089 - fix(qwikcity): Fix route-matcher regression [#​5080](https://togithub.com/BuilderIO/qwik/issues/5080) by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5112 - docs(authjs): use pathname in protected route example by [@​ulic75](https://togithub.com/ulic75) in [QwikDev/qwik#5115 - starters: Ensure that VSCode emmet uses JSX syntax for self-closing tags by [@​colelawrence](https://togithub.com/colelawrence) in [QwikDev/qwik#5116 - fix(eslint): Support explicit export with loader-location by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5121 - fix v1.2 playground by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5124 - feat: Add route rewriting by [@​claudioshiver](https://togithub.com/claudioshiver) in [QwikDev/qwik#5122 - docs(qwik-city): Add docs for routes rewriting by [@​claudioshiver](https://togithub.com/claudioshiver) in [QwikDev/qwik#5127 - bug(vite): populate rollup cache after transform by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5130 - feat(qrl): add resolved by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5118 - test(qwik-city): add route-matcher case with two rest params by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5133 - Issue 5065 by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5131 - fix(qwik-city): Correctly SSG routes even with `trailingSlash: false` by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5132 - Issue 5126 by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5135 - chore(insights): upgrade drizzle by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5134 - fix(qwik-city): correct validator failed type by [@​wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5137 - fix(insight): Correct DB returning too much data error by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5139 - Revert "chore(insights): upgrade drizzle" by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5138 - docs: improve descriptions for aws, azure and gcp integrations by [@​WilliamEspegren](https://togithub.com/WilliamEspegren) in [QwikDev/qwik#5144 - feat: provide compatibility with angular by [@​dmitry-stepanenko](https://togithub.com/dmitry-stepanenko) in [QwikDev/qwik#5119 - 1.2.11 by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5145 ##### New Contributors - [@​josemartinez111](https://togithub.com/josemartinez111) made their first contribution in [QwikDev/qwik#4878 - [@​blove](https://togithub.com/blove) made their first contribution in [QwikDev/qwik#5085 - [@​adcar](https://togithub.com/adcar) made their first contribution in [QwikDev/qwik#5090 - [@​diecodev](https://togithub.com/diecodev) made their first contribution in [QwikDev/qwik#4745 - [@​adaliszk](https://togithub.com/adaliszk) made their first contribution in [QwikDev/qwik#5110 - [@​colelawrence](https://togithub.com/colelawrence) made their first contribution in [QwikDev/qwik#5116 - [@​claudioshiver](https://togithub.com/claudioshiver) made their first contribution in [QwikDev/qwik#5122 - [@​WilliamEspegren](https://togithub.com/WilliamEspegren) made their first contribution in [QwikDev/qwik#5144 **Full Changelog**: QwikDev/qwik@v1.2.10...v1.2.11 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix emmet behavior for base
What is it?
Description
Also applies to
input,img, etc.Checklist: