fix: loader type

[wtlin1228]

Overview

Fix loader type for the case: loaderQrl returns fail(...) without any validator.

Related issue: #3979

What is it?

• Feature / enhancement
• Bug
• Docs / tests / types / typos

Description

I only do StrictUnion when the loaderQrl returns fail(...) to keep the most simple case's type the same.

// Loader<number>
export const useLoader1 = routeLoader$(() => 123); 

// Loader<{
//     foo: number;
// }>
export const useLoader2 = routeLoader$(() => ({ foo: 123 })); 

And for those returning fail(...):

// Loader<{
//     loaderFailedReason?: string | undefined;
//     failed?: true | undefined;
//     pet?: undefined;
// } | {
//     pet?: string | undefined;
//     failed?: undefined;
//     loaderFailedReason?: undefined;
// }>
export const useRandomFailedLoader = routeLoader$(({ fail }) => {
  if (Math.random() > 0.5) {
    return fail(500, {
      loaderFailedReason: "Reach Limit",
    });
  }

  return {
    pet: "guinea pig",
  };
});

Use cases and why

• 1. One use case
• 2. Another use case

Checklist:

• My code follows the developer guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• Added new tests to cover the fix / functionality

[netlify]

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	00e1da6

[mhevery]

Thank you for the contribution!

I see you have an issue with reproduction, but I don't see a test. Did you forget to check it in?

[wtlin1228]

Thank you for the contribution!

I see you have an issue with reproduction, but I don't see a test. Did you forget to check it in?

Hi @mhevery, the test is starters/apps/qwikcity-test/src/routes/(common)/loaders/issue3979/index.tsx.

[mhevery]

Thank you for your contribution. ❤️