Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrl): add resolved #5118

Merged
merged 1 commit into from
Sep 8, 2023
Merged

feat(qrl): add resolved #5118

merged 1 commit into from
Sep 8, 2023

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Sep 6, 2023

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Implements #5117

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@netlify
Copy link

netlify bot commented Sep 6, 2023

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f72d3e4

@wmertens
Copy link
Member Author

wmertens commented Sep 6, 2023

Not sure if this actually works yet :-)
But this is a first stab at the functionality, seeing if the tests still pass and if the approach looks good?

@mhevery
Copy link
Contributor

mhevery commented Sep 6, 2023

Let me know when you are ready to merge. I think having a test would be nice.

@wmertens
Copy link
Member Author

wmertens commented Sep 7, 2023

I think I covered all the docs and I added a test.

Assuming that the only way QRLs ever get resolved is via .resolve(), I think we're good to go.

@zanettin zanettin added COMP: DX Developer Experience related issue STATUS-2: PR waiting for review This PR is waiting for review and approval before merge labels Sep 7, 2023
@mhevery mhevery merged commit 549a7be into QwikDev:main Sep 8, 2023
19 checks passed
kodiakhq bot pushed a commit to ascorbic/unpic-img that referenced this pull request Sep 17, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik)) | [`1.2.10` -> `1.2.11`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.10/1.2.11) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.2.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.2.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.2.10/1.2.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.2.10/1.2.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>BuilderIO/qwik (@&#8203;builder.io/qwik)</summary>

### [`v1.2.11`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.2.11)

[Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.10...v1.2.11)

##### What's Changed

-   Add useId() docs and demo component by [@&#8203;n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5037
-   add n8sabes to contributors by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5040
-   chore: array index can be typed as number by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#4748
-   Modular Forms: Fix incorrect type in example by [@&#8203;RaeesBhatti](https://togithub.com/RaeesBhatti) in [QwikDev/qwik#5036
-   docs: add docs about server$ middleware by [@&#8203;RaeesBhatti](https://togithub.com/RaeesBhatti) in [QwikDev/qwik#5033
-   feat: add jsx-a eslint rule by [@&#8203;kerbelp](https://togithub.com/kerbelp) in [QwikDev/qwik#4256
-   docs: Adding Example for useOnWindow  by [@&#8203;josemartinez111](https://togithub.com/josemartinez111) in [QwikDev/qwik#4878
-   chore: supabase-auth-helpers-qwik: update devDependencies by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5041
-   fix: action type by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5034
-   chore: add more debug info to build by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5047
-   fix: align `function` and `()=>` behavior for JSX transpilation by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5012
-   fix(core): correctly handle serialization of Signal of X and naked X by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5013
-   fix(core): pass through decorators by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5052
-   fix(qwik-city): correct rest route regression by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5054
-   fix: QwikInsights path resolution by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5051
-   docs: add qwikInsights vite plugin by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5055
-   docs: change [@&#8203;builder](https://togithub.com/builder).io/qwik-labs version by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5057
-   docs: add prettier as devDependencies ([#&#8203;5059](https://togithub.com/BuilderIO/qwik/issues/5059)) by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5061
-   chore: fix .nvmrc with the right version by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5060
-   docs: Document Relative URLs in Loaders by [@&#8203;n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5063
-   docs: Cookbook recipe for playing audio and video media on iOS devices by [@&#8203;n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5066
-   Revert "docs: Cookbook recipe for playing audio and video media on iOS devices" by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5073
-   fix(qwik-city): do not write into a closed stream by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5074
-   fix: loader type by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5062
-   Add media controller to cookbook by [@&#8203;n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5078
-   Fix the loader document by [@&#8203;n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5077
-   feat: i18n $localize starter by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5070
-   Loader doc consistency by [@&#8203;n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5082
-   Enhance Media Controller Cookbook Recipe and fix fluid layout for smaller screens by [@&#8203;n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5081
-   Remove overlooked console.log() from cookbook recipe by [@&#8203;n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5083
-   Update cookbook to stream 1080p video content by [@&#8203;n8sabes](https://togithub.com/n8sabes) in [QwikDev/qwik#5084
-   Update pages.json by [@&#8203;blove](https://togithub.com/blove) in [QwikDev/qwik#5085
-   fix: library starter don't bundle dependencies by [@&#8203;wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#2008
-   Fixed typo in Docs > Integrations > Prisma by [@&#8203;adcar](https://togithub.com/adcar) in [QwikDev/qwik#5090
-   starter: Update deps and code of supabase auth helpers qwik pkg by [@&#8203;diecodev](https://togithub.com/diecodev) in [QwikDev/qwik#4745
-   docs: Image updates - Qwik City  by [@&#8203;hamatoyogi](https://togithub.com/hamatoyogi) in [QwikDev/qwik#5098
-   docs: update the basic projection tutorial by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5093
-   docs: update the implicit reactivity tutorial by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5092
-   docs: remove outdated props store tutorial by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5095
-   fix: remove missing tutorial ([#&#8203;5105](https://togithub.com/BuilderIO/qwik/issues/5105)) by [@&#8203;gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5106
-   docs: fix "Endpoints" link on Qwik City -> Routing page by [@&#8203;jakovljevic-mladen](https://togithub.com/jakovljevic-mladen) in [QwikDev/qwik#5107
-   chore: release qwik-auth 0.1.1 by [@&#8203;ulic75](https://togithub.com/ulic75) in [QwikDev/qwik#5103
-   docs: update reactivity's counter example by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5091
-   chore(eslint-plugin-qwik): change eslint to ^8.45 by [@&#8203;adaliszk](https://togithub.com/adaliszk) in [QwikDev/qwik#5110
-   docs: fix mismatch title for implicit reactivity tutorial by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5111
-   feat(optimizer): add qwikVite configuration option optimizerOptions.inlineStylesUpToBytes by [@&#8203;jaroel](https://togithub.com/jaroel) in [QwikDev/qwik#5089
-   fix(qwikcity): Fix route-matcher regression [#&#8203;5080](https://togithub.com/BuilderIO/qwik/issues/5080) by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5112
-   docs(authjs): use pathname in protected route example by [@&#8203;ulic75](https://togithub.com/ulic75) in [QwikDev/qwik#5115
-   starters: Ensure that VSCode emmet uses JSX syntax for self-closing tags by [@&#8203;colelawrence](https://togithub.com/colelawrence) in [QwikDev/qwik#5116
-   fix(eslint): Support explicit export with loader-location by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5121
-   fix v1.2 playground by [@&#8203;wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5124
-   feat: Add route rewriting by [@&#8203;claudioshiver](https://togithub.com/claudioshiver) in [QwikDev/qwik#5122
-   docs(qwik-city): Add docs for routes rewriting by [@&#8203;claudioshiver](https://togithub.com/claudioshiver) in [QwikDev/qwik#5127
-   bug(vite): populate rollup cache after transform by [@&#8203;wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5130
-   feat(qrl): add resolved by [@&#8203;wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5118
-   test(qwik-city): add route-matcher case with two rest params by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5133
-   Issue 5065 by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5131
-   fix(qwik-city): Correctly SSG routes even with `trailingSlash: false` by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5132
-   Issue 5126 by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5135
-   chore(insights): upgrade drizzle by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5134
-   fix(qwik-city): correct validator failed type by [@&#8203;wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#5137
-   fix(insight): Correct DB returning too much data error by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5139
-   Revert "chore(insights): upgrade drizzle" by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5138
-   docs: improve descriptions for aws, azure and gcp integrations by [@&#8203;WilliamEspegren](https://togithub.com/WilliamEspegren) in [QwikDev/qwik#5144
-   feat: provide compatibility with angular by [@&#8203;dmitry-stepanenko](https://togithub.com/dmitry-stepanenko) in [QwikDev/qwik#5119
-   1.2.11 by [@&#8203;mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5145

##### New Contributors

-   [@&#8203;josemartinez111](https://togithub.com/josemartinez111) made their first contribution in [QwikDev/qwik#4878
-   [@&#8203;blove](https://togithub.com/blove) made their first contribution in [QwikDev/qwik#5085
-   [@&#8203;adcar](https://togithub.com/adcar) made their first contribution in [QwikDev/qwik#5090
-   [@&#8203;diecodev](https://togithub.com/diecodev) made their first contribution in [QwikDev/qwik#4745
-   [@&#8203;adaliszk](https://togithub.com/adaliszk) made their first contribution in [QwikDev/qwik#5110
-   [@&#8203;colelawrence](https://togithub.com/colelawrence) made their first contribution in [QwikDev/qwik#5116
-   [@&#8203;claudioshiver](https://togithub.com/claudioshiver) made their first contribution in [QwikDev/qwik#5122
-   [@&#8203;WilliamEspegren](https://togithub.com/WilliamEspegren) made their first contribution in [QwikDev/qwik#5144

**Full Changelog**: QwikDev/qwik@v1.2.10...v1.2.11

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: DX Developer Experience related issue STATUS-2: PR waiting for review This PR is waiting for review and approval before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants