Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): change indicator side from left to the right #5903

Merged
merged 3 commits into from
Feb 28, 2024
Merged

chore(docs): change indicator side from left to the right #5903

merged 3 commits into from
Feb 28, 2024

Conversation

LazyClicks
Copy link
Contributor

@LazyClicks LazyClicks commented Feb 28, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

switched the updated indicator to be on the right of the a tag text, as on desktop it is not visible due to the small sidebar width
after change
vs
before change

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Feb 28, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5a75021

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome 😎 @LazyClicks
Nice catch

@gioboa gioboa changed the title chore: changed updated indicator side from left to the right of the a tag text chore(docs): change indicator side from left to the right Feb 28, 2024
@gioboa gioboa added the COMP: docs Improvements or additions to documentation label Feb 28, 2024
@gioboa gioboa merged commit 301436c into QwikDev:main Feb 28, 2024
23 checks passed
@LazyClicks LazyClicks deleted the chore-changed-the-side-of-the-updated-indicator branch February 28, 2024 17:18
@LazyClicks LazyClicks restored the chore-changed-the-side-of-the-updated-indicator branch February 28, 2024 17:18
@LazyClicks LazyClicks deleted the chore-changed-the-side-of-the-updated-indicator branch February 28, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants