Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow any supported extension on entry points #6162

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Apr 26, 2024

Overview

#6100

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@JerryWu1234
Copy link
Contributor Author

JerryWu1234 commented Apr 26, 2024

image
image

it can work, and after I will fix the tests

@PatrickJS
Copy link
Member

looks good. let us know when the PR is ready

@JerryWu1234 JerryWu1234 marked this pull request as ready for review April 30, 2024 03:19
@JerryWu1234
Copy link
Contributor Author

looks good. let us know when the PR is ready

please help to review

@PatrickJS
Copy link
Member

@JerryWu1234 if it works can you fix the tests

@JerryWu1234
Copy link
Contributor Author

@JerryWu1234 if it works can you fix the tests

lol。 I forgot it I didn't fix tests yet.
today I'll fix it

@wmertens wmertens changed the title fix: fix a bug feat: allow any supported extension on entry points Apr 30, 2024
@JerryWu1234
Copy link
Contributor Author

@JerryWu1234 if it works can you fix the tests

done

@wmertens
Copy link
Member

wmertens commented Apr 30, 2024

can you git checkout origin/main -- pnpm-lock.yaml? That's definitely not part of this PR.

And the tests still fail :)

@JerryWu1234
Copy link
Contributor Author

git checkout origin/main -- pnpm-lock.yaml

let me try.

@JerryWu1234
Copy link
Contributor Author

please last check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants