Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: utf-8 lowercase #6365

Merged
merged 5 commits into from
May 23, 2024
Merged

fix: utf-8 lowercase #6365

merged 5 commits into from
May 23, 2024

Conversation

PatrickJS
Copy link
Member

@PatrickJS PatrickJS commented May 23, 2024 •
edited
Loading

fix utf-8 lowercase

The default character encoding used in HTML5 is UTF-8. This means if you include at the top of your HTML file (which declares that it's an HTML5 file), it'll automatically use UTF-8 unless specified otherwise.

Most browsers use UTF-8 by default if no character encoding is specified. But because that's not guaranteed, it's better to just include a character encoding specification using the tag in your HTML file.

@netlify Netlify
Copy link

netlify bot commented May 23, 2024 •
edited
Loading

✅ Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit 0eb936a
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/664eb6bde121cf0008fe6bc0
😎 Deploy Preview https://deploy-preview-6365--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented May 23, 2024 •
edited
Loading

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0eb936a
Status: ✅  Deploy successful!
Preview URL: https://356bc393.qwik-8nx.pages.dev
Branch Preview URL: https://fix-utf-8-lower-case-is-corr.qwik-8nx.pages.dev

View logs

thejackshelton
thejackshelton approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@thejackshelton thejackshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@PatrickJS PatrickJS merged commit 5c42425 into main May 23, 2024
28 checks passed
@PatrickJS PatrickJS deleted the fix-utf-8-lower-case-is-correct branch May 23, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejackshelton thejackshelton thejackshelton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrickJS @thejackshelton