-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add qwik add command for Nightwatch. #6426
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
710a8ac
to
fd64ad8
Compare
fd64ad8
to
b44ba43
Compare
Hi @garg3133 Thanks for this PR, can you add few test examples pls? |
Ohh didn't realize I forgot to push the example file. Thanks! |
@gioboa I've added the example test. |
Thanks @garg3133
Am I missing something? |
This is strange because How can I test this integration locally myself? How I've created this PR is by creating a new Qwik project using |
you can build the Qwik core with
Install the new deps and then you can run The CLI is a small part of Qwik package but I usually build and link everything to avoid clashes. |
So, here are the steps I followed:
And the test runs perfectly fine for me. |
I see, thanks. @thejackshelton are you able to run it? Maybe my local environment is not perfectly configured. |
Thanks a lot @garg3133 ! We're planning to move integrations into community plugins under the "QwikCommunity" org so we could share the maintenance work with community plugin maintainers. It's first pending that we'll implement this QwikDev/qwik-evolution#20 and after that it'll be easy to make sure this will be created as a plugin. So I'm keeping this PR opened until we'll implement the plugin system Thanks again! 🙏 |
Overview
Add an integration for Nightwatch, an e2e testing framework that allows users to run their tests against real browsers.
What is it?
Description
Add a starter for Nightwatch integration.
Use cases and why
Checklist:
/cc: @AutomatedTester