Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: site footer + banner changes #6438

Merged
merged 4 commits into from
Jun 2, 2024
Merged

docs: site footer + banner changes #6438

merged 4 commits into from
Jun 2, 2024

Conversation

thejackshelton
Copy link
Member

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@thejackshelton thejackshelton requested review from a team as code owners June 2, 2024 02:44
Copy link

netlify bot commented Jun 2, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit 310eae6
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/665bde1b84308800080e615b
😎 Deploy Preview https://deploy-preview-6438--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Jun 2, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 310eae6
Status: ✅  Deploy successful!
Preview URL: https://8bd052ec.qwik-8nx.pages.dev
Branch Preview URL: https://fix-docs.qwik-8nx.pages.dev

View logs

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great @thejackshelton
Thanks

@gioboa
Copy link
Member

gioboa commented Jun 2, 2024

image

@gioboa gioboa merged commit e943b73 into main Jun 2, 2024
28 checks passed
@gioboa gioboa deleted the fix-docs branch June 2, 2024 10:05
@shairez
Copy link
Contributor

shairez commented Jun 2, 2024

Thanks for reviewing @gioboa !

@thejackshelton we need to also add the "special sponsor" section above the fold, let's sync about it today

@thejackshelton
Copy link
Member Author

Thanks for reviewing @gioboa !

@thejackshelton we need to also add the "special sponsor" section above the fold, let's sync about it today

Sounds good. Will reach out.

@thejackshelton
Copy link
Member Author

That's great @thejackshelton Thanks

Thanks for the review Giorgio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants