Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Vite build.assetsDir config only in the client build #6527

Closed
wants to merge 10 commits into from

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Jun 12, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@gioboa gioboa requested a review from a team as a code owner June 12, 2024 18:21
Copy link

netlify bot commented Jun 12, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 34b6c4f

Copy link

pkg-pr-new bot commented Jun 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 34b6c4f

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6527

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6527

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6527

create-qwik

npm i https://pkg.pr.new/create-qwik@6527

@shairez
Copy link
Contributor

shairez commented Jun 13, 2024

Thanks @gioboa !
seems like the unit test is failing

Is this PR still "work in progress"?

@gioboa gioboa marked this pull request as draft June 13, 2024 11:22
@gioboa
Copy link
Member Author

gioboa commented Jun 13, 2024

Yep, I will fix all the assetsDir issues here

@shairez
Copy link
Contributor

shairez commented Jun 13, 2024

Thanks @gioboa ! you rock! 🙏

@gioboa gioboa closed this Jun 20, 2024
@gioboa gioboa deleted the feat/qwikVite branch June 25, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants