Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(city): clean up code #6581

Merged
merged 2 commits into from
Jun 20, 2024
Merged

refactor(city): clean up code #6581

merged 2 commits into from
Jun 20, 2024

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Jun 20, 2024

Overview

What is it?

  • Refactor

Description

Clean up the server functions code in Qwik city to make it easier to understand and to debug.

👉 NO PUBLIC API WAS CHANGED IN THIS PR

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@shairez shairez requested a review from a team as a code owner June 20, 2024 00:08
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit 58b663c
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6674258854676b0008220ee3
😎 Deploy Preview https://deploy-preview-6581--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jun 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 58b663c

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6581

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6581

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6581

create-qwik

npm i https://pkg.pr.new/create-qwik@6581

Copy link

cloudflare-workers-and-pages bot commented Jun 20, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58b663c
Status: ✅  Deploy successful!
Preview URL: https://0d228531.qwik-8nx.pages.dev
Branch Preview URL: https://pr-clean-city.qwik-8nx.pages.dev

View logs

@shairez shairez merged commit 691ca1a into main Jun 20, 2024
30 checks passed
@shairez shairez deleted the pr-clean-city branch June 20, 2024 13:21
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants