Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed library starter wrong Qwik version #6757

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Aug 2, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

When creating a library via the CLI, it creates the wrong Qwik version in devDependencies

This fixes it and adds a test to make sure this bug won't come back.

(In the future we are planning a more robust testing system for qwik starters tests)

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@shairez shairez requested a review from a team as a code owner August 2, 2024 22:36
Copy link

changeset-bot bot commented Aug 2, 2024

🦋 Changeset detected

Latest commit: 5d7a0cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
create-qwik Patch
@builder.io/qwik Patch
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 2, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 5d7a0cd

Copy link

pkg-pr-new bot commented Aug 2, 2024

commit: 5d7a0cd

npm i https://pkg.pr.new/@builder.io/qwik@6757
npm i https://pkg.pr.new/@builder.io/qwik-city@6757
npm i https://pkg.pr.new/eslint-plugin-qwik@6757
npm i https://pkg.pr.new/create-qwik@6757

Open in Stackblitz

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

@wmertens wmertens merged commit 16c36da into main Aug 3, 2024
19 checks passed
@wmertens wmertens deleted the pr-fix-create-lib branch August 3, 2024 05:46
This was referenced Aug 2, 2024
@shairez shairez self-assigned this Aug 4, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 26, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants