-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed library starter wrong Qwik version #6757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5d7a0cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit:
|
wmertens
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦖
This was referenced Aug 2, 2024
Merged
maiieul
added a commit
to maiieul/qwik
that referenced
this pull request
Aug 26, 2024
This reverts commit 16c36da.
maiieul
added a commit
to maiieul/qwik
that referenced
this pull request
Aug 27, 2024
This reverts commit 16c36da.
maiieul
added a commit
to maiieul/qwik
that referenced
this pull request
Aug 27, 2024
This reverts commit 16c36da.
maiieul
added a commit
to maiieul/qwik
that referenced
this pull request
Aug 27, 2024
This reverts commit 16c36da.
maiieul
added a commit
to maiieul/qwik
that referenced
this pull request
Aug 27, 2024
This reverts commit 16c36da.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
When creating a library via the CLI, it creates the wrong Qwik version in
devDependencies
This fixes it and adds a test to make sure this bug won't come back.
(In the future we are planning a more robust testing system for qwik starters tests)
Checklist: