Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add new showcase site #6776

Merged
merged 2 commits into from
Aug 18, 2024
Merged

docs: add new showcase site #6776

merged 2 commits into from
Aug 18, 2024

Conversation

DevWeb13
Copy link
Contributor

@DevWeb13 DevWeb13 commented Aug 7, 2024

Add learn-qwik.com

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Add learn-qwik.com
@DevWeb13 DevWeb13 requested a review from a team as a code owner August 7, 2024 11:06
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: 19d94ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the website with https://pagespeed.web.dev/ and we can't add this webiste because the score is too low
image
Can you try to fix it up?

@gioboa gioboa changed the title Update pages.json docs: add new showcase site Aug 7, 2024
@gioboa gioboa added WAITING FOR: user Further information is requested from the issue / pr opener COMP: docs Improvements or additions to documentation labels Aug 7, 2024
@DevWeb13
Copy link
Contributor Author

DevWeb13 commented Aug 7, 2024 via email

@DevWeb13
Copy link
Contributor Author

Hi,
I think the performances are good from now on:
Capture d’écran du 2024-08-18 21-15-14

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good to me.
@DevWeb13 thanks

@gioboa gioboa enabled auto-merge (squash) August 18, 2024 19:22
@gioboa gioboa merged commit cb69e99 into QwikDev:main Aug 18, 2024
13 checks passed
Copy link

pkg-pr-new bot commented Aug 18, 2024

commit: 5cf7518

npm i https://pkg.pr.new/@builder.io/qwik@6776
npm i https://pkg.pr.new/@builder.io/qwik-city@6776
npm i https://pkg.pr.new/eslint-plugin-qwik@6776
npm i https://pkg.pr.new/create-qwik@6776

Open in Stackblitz

@DevWeb13
Copy link
Contributor Author

I received this email, and I don't know what it means. Do I need to take any action on my end?
Thank you.

Capture d’écran du 2024-08-19 10-01-15
Capture d’écran du 2024-08-19 10-01-30

@gioboa
Copy link
Member

gioboa commented Aug 19, 2024

I received this email, and I don't know what it means. Do I need to take any action on my end? Thank you.

Hi, you can ignore it. 👍 The PR is fine.

@DevWeb13
Copy link
Contributor Author

Ok thanks my friend.

maiieul added a commit to maiieul/qwik that referenced this pull request Aug 26, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
wmertens pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation WAITING FOR: user Further information is requested from the issue / pr opener
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants