Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CI not uploading dot files #6876

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fixed CI not uploading dot files #6876

merged 2 commits into from
Sep 12, 2024

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Sep 11, 2024

Overview

It took us a few hours of debugging to realize that our new version doesn't have a .eslintrc.cjs file because there was a hidden breaking change introduced in a minor version of upload-artifact

Plus this PR fixes a typo in one of the changeset files

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

@shairez shairez requested a review from a team as a code owner September 11, 2024 22:54
Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: e70dee1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Sep 11, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6876
npm i https://pkg.pr.new/@builder.io/qwik-city@6876
npm i https://pkg.pr.new/eslint-plugin-qwik@6876
npm i https://pkg.pr.new/create-qwik@6876

commit: e70dee1

Copy link
Contributor

github-actions bot commented Sep 11, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview e70dee1

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit bb42772 into main Sep 12, 2024
18 checks passed
@wmertens wmertens deleted the pr-fix-artifact branch September 12, 2024 05:54
wmertens pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants