Add option to exclude topics #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blootsvoets
reviewed
Feb 14, 2019
There was a problem hiding this comment.
LGTM, except for small comment. Should also be be fixed with #39, by adding a config file.
| @Parameter(names = {"--max-files-per-topic"}, description = "Maximum number of records to process, per topic. Set below 1 to disable this option.") | ||
| public int maxFilesPerTopic = 0; | ||
|
|
||
| @Parameter(names = {"--exclude-topics"}, description = "Topics to exclude when processing the records.") |
There was a problem hiding this comment.
Parameter name should be singular, since on the command line you specify one value per tag, e.g. --exclude-topic topicA --exclude-topic topicB.
There was a problem hiding this comment.
It works as a comma-separated list. Is is preferred to use flag for each topic ?
There was a problem hiding this comment.
Based on JCommander docs, that is what I thought. I also think it is more clear from CLI point of view.
There was a problem hiding this comment.
Okay I will update.
blootsvoets
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to exclude certain topics when there are a lot of topics under the directory and will not be feasible to add each one as an output path in order to exclude a little number of topics.