Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use entry_points instead of scripts for CLI #23

Merged
merged 2 commits into from
Jun 4, 2019

Conversation

bollwyvl
Copy link
Contributor

As promised, per #22, this moves bin/pyshacl to pyshacl/cli.py, and uses entry_points for locating it at install time.

Also happy to work up an azure-pipelines.yaml to get some more robotic eyes on this project... though you'd probably have to set up an account: it's a bit awkward, and the docs aren't fantastic, but given it's platform reach, performance, etc. it's hard to beat unless you need fine-grain incremental building.

@ashleysommer
Copy link
Collaborator

@bollwyvl
Will this change require documentation changes in the README?
Will users be able to call the cli app in the same way as they currently do?

Regarding azure-pipelines, does Azure offer a free tier for this kind of thing at all?
I've played with Bitbucket-pipelines a bit, maybe I could set that up for more automated testing.

@bollwyvl
Copy link
Contributor Author

Will this change require documentation changes in the README?

Nope. pyshacl will just keep working. the cli main function itself would now be importable... this can be handy for integrators, but you don't strictly need to advertise it. the first commit went a bridge too far and moved the sys.exits (not fun to catch), but that can be a PR for another day. however, it would certainly be good to test it :P

Regarding azure-pipelines, does Azure offer a free tier for this kind of thing at all?

Yeah, for open source: unlimited jobs up to an hour apiece, up to ten at a time. partially to nip the atlassian digression in the bud, here's what ci could be like:

https://dev.azure.com/nickbollweg/pyshacl/_build/results?buildId=292&view=results

Or if you prefer, right on github:

https://github.com/bollwyvl/pySHACL/pull/1/checks?check_run_id=129123119

i have some ui beefs (especially on mobile) but you can't beat the price.

I already had an account, so it only took a few minutes to get it set up. you'd just need an account over there, and you do have to give the bot push access, i think. you go through the github marketplace.

the syntax is a bit annoying, as it's not real yaml (no anchors, etc) so they kinda force you to use their crazy n pass templating system. but for simple stuff, it's simple enough, and it makes complex stuff possible in a way that other ci systems don't approach until you get into jenkins land.

I've played with Bitbucket-pipelines a bit, maybe I could set that up for more automated testing.

of course, up to you, but... see above. while i certainly mistrust microsoft, i actively dislike atlassian.

@ashleysommer
Copy link
Collaborator

Woops, sorry I forgot to merge this.

@ashleysommer ashleysommer merged commit 0638935 into RDFLib:master Jun 4, 2019
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jun 4, 2019 via email

ashleysommer added a commit that referenced this pull request Aug 8, 2019
- SHACL Triple Rules
- SHACL SPARQL Rules
New option in the cli application to enable advanced features with `--advanced`.
- Changed the `-a` shortcut to mean `--advanced` rather than `--abort`.
New tests for the advanced features

Changed usage of setup.py scripts, to proper cli entrypoints. #23
- This should not affect end user usability of the pyshacl script.
Updated README.md to reflect changes including Advanced Features, and cli `--advanced` arg.
Updated feature matrix to add section for SHACL Advanced Features.
Fix owl:import typo #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants