Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue 981 fix #1075

Closed
wants to merge 2 commits into from
Closed

issue 981 fix #1075

wants to merge 2 commits into from

Conversation

ayush609
Copy link

extensiondecider file to decide the correct extension based on the rdf format and if incorrect file is given create new file with correct extension

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 75.168% when pulling 21fa199 on ayush609:issue981 into 037ea51 on RDFLib:master.

@coveralls
Copy link

coveralls commented May 27, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 75.085% when pulling 1e13c1e on ayush609:issue981 into 037ea51 on RDFLib:master.

@ashleysommer ashleysommer mentioned this pull request May 27, 2020
Closed
@ashleysommer
Copy link
Contributor

@ayush609
There is already two PRs for a fix for #981
See: #1046
and #1064

@nicholascar
Copy link
Member

nicholascar commented Jun 1, 2020 •
edited
Loading

I've chosen PR #1046 for this. It uses the in-built guess_format() function so is much shorter, and includes tests! Please, please include tests for all PRs.

@nicholascar nicholascar closed this Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ayush609 @coveralls @ashleysommer @nicholascar @ayush17034