Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make csv2rdf work in py3 #1117

Merged
merged 5 commits into from
Aug 27, 2020
Merged

make csv2rdf work in py3 #1117

merged 5 commits into from
Aug 27, 2020

Conversation

dwinston
Copy link
Contributor

Fixes #1116

Proposed Changes

  • use next built-in for iteration
  • change offending utf-8 lines as Python 3 handles Unicode
  • add basic sanity check test for CLI using subprocess

@coveralls
Copy link

coveralls commented Jun 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 75.799% when pulling fe06a14 on dwinston:fix-csv2rdf-for-py3 into c050f27 on RDFLib:master.

@nicholascar
Copy link
Member

Hi @dwinston, I see that this PR is just failing one test for a couple of Python versions. Can you please attend to that and the comments above and then I'd be happy for a final review and a merge? Thanks, Nick

@dwinston
Copy link
Contributor Author

dwinston commented Aug 5, 2020

@nicholascar done. thanks!

@nicholascar nicholascar merged commit 5799986 into RDFLib:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidianjoy davidianjoy davidianjoy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

csv2rdf uses Python 2 features broken by Python 3
4 participants
@dwinston @coveralls @nicholascar @davidianjoy