Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate some more Graph API surface #1151

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

ashleysommer
Copy link
Contributor

Deprecate some more Graph API surface that will be removed in RDFLib 6.0.0

@ashleysommer
Copy link
Contributor Author

Can't merge this yet. A lot of tests are failing.
Turns out some parts of rdflib (like a lot of tests) do from rdflib.graph import RDFS
With RDFS removed as an import here, those locations now fail.
I'll update this soon.

@nicholascar
Copy link
Member

Turns out some parts of rdflib (like a lot of tests) do from rdflib.graph import RDFS

Yes, I've seen this and occasionally have done that myself, by mistake. It would be good to update everything so that RDFS, along with all namespaces are always imported from the same place, rdflib.namespace, not rdflib.graph. Good to finally address this small niggle

@ashleysommer
Copy link
Contributor Author

Ok, turns out I was wrong. It wasn't used in the tests, but in the inline doctests in graph.py, I didn't know Travis tests those too.
I've updated those so should pass tests now.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 75.496% when pulling 2fc55b3 on deprecate_graph_api into 1a70666 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 75.496% when pulling 2fc55b3 on deprecate_graph_api into 1a70666 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 75.496% when pulling 2fc55b3 on deprecate_graph_api into 1a70666 on master.

@ashleysommer
Copy link
Contributor Author

All tests pass, good to merge 👍

@nicholascar nicholascar merged commit 652d2e6 into master Aug 27, 2020
@nicholascar nicholascar deleted the deprecate_graph_api branch August 27, 2020 07:33
@white-gecko white-gecko added this to the rdflib 6.0.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants