-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue rdflib jsonld 85 - link header support in URLInputSource #1281
base: main
Are you sure you want to change the base?
Conversation
The test for link header profile uses a live service which can be unreliable. Test is removed until a mock can be provided.
@datadavev thanks for this PR. I recall the issue you are addressing now. I'll just need to think about this for a day or two and chat with another person (see below) about this before approving. Just want to ensure the handling doesn't get in the way of other Content Negotiation stuff. @rob-metalinkage can you take a look at this? This may solve an issue for JSON-LD but create issues for other RDF formats. We need to discuss before accepting. |
A quick explanation of when jsonld should be following a link header - on parsing inputs? My only concern is that the parser should work properly if the JSON-LD uses contexts - and should support serialisation respecting use of contexts rather than brute-force turning everything into full URIs - JSON-LD should support serialisation to specific schemas with contexts. |
Fixes specifically rdflib-jsonld-85 by adding general support for following link headers in URLInputSource.
Proposed Changes