Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace incomplete example in intro_to_sparql.rst #1331

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Replace incomplete example in intro_to_sparql.rst #1331

merged 1 commit into from
Jun 1, 2021

Conversation

tombaker
Copy link
Contributor

Fixes incomplete example in intro_to_sparql.rst

TimBL's FOAF page no longer has any foaf:knows triples, so a beginner will not be able to reproduce the results obtained in the example, as is. The query string is also missing a PREFIX binding for foaf:.

Proposed Changes

  • As TimBL's FOAF page no longer has any foaf:knows triples, uses Danbri's FOAF page, which does.
  • Minor rewordings in third paragraph, for clarity.
  • Assigns query string to variable so that it can be used in a second example (below).
  • Minor rewording in paragraph starting "The results are tuples...".
  • Provides second, short example, illustrating the use of initNs
  • Uses f-string illustrating different ways to access result values.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.705% when pulling a4a9d06 on tombaker:master into 58b23fd on RDFLib:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.705% when pulling a4a9d06 on tombaker:master into 58b23fd on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.705% when pulling a4a9d06 on tombaker:master into 58b23fd on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.705% when pulling a4a9d06 on tombaker:master into 58b23fd on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.705% when pulling a4a9d06 on tombaker:master into 58b23fd on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.705% when pulling a4a9d06 on tombaker:master into 58b23fd on RDFLib:master.

@nicholascar nicholascar merged commit a09128b into RDFLib:master Jun 1, 2021
@nicholascar
Copy link
Member

Hi @tombaker thnks very much for the updated docco! I am preparing a rather large total doc update in readiness for a 6.0.0 release of RDFlib soon, but I hand't picked up on this particular issue so this is very much appreciated.

@tombaker
Copy link
Contributor Author

@nicholascar Thank you for letting me know that my modest contributions are appreciated :-) If I come across other places where small improvements might be made, will submit them for consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants