Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined name: tmppath --> self.tmppath #1438

Merged
merged 1 commit into from Oct 13, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 12, 2021

$ flake8 . --count --select=E9,F63,F7,F82,Y --show-source --statistics

./rdflib/test/test_rules.py:58:27: F821 undefined name 'tmppath'
            shutil.rmtree(tmppath)
                          ^

Proposed Changes

  • tmppath --> self.tmppath

@aucampia
Copy link
Member

I think it may make sense to add some of these checks to the drone pipeline.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 12, 2021

flake8 is already run in drone but all issues are ignored. There are still two more undefined names that are head-scratchers.

@nicholascar
Copy link
Member

Thanks @cclauss

@nicholascar nicholascar merged commit 1729243 into RDFLib:master Oct 13, 2021
@cclauss cclauss deleted the fix-undefined-names branch October 14, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants