Add IdentifiedNode abstract intermediary class #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds and exposes an intermediary class `IdentifiedNode` as a superclass of `URIRef` and `BNode`. From review of the subclass methods for identical implementations, two appeared to be able to move into this superclass. Thanks to Nicholas Car for finding this pragmatic name. This patch addresses at least some of Issue 1526. References: * RDFLib#1526 Cc: Nicholas Car <nicholas.car@surroundaustralia.com> Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
aucampia
approved these changes
Jan 18, 2022
nicholascar
approved these changes
Jan 20, 2022
yes, I disabled them now and will re-enable once that PR is merged to avoid confusion from others, the PR for pre-commits has links to my fork which has it enabled for illustrative purposes. |
ashleysommer
added a commit
that referenced
this pull request
Aug 1, 2024
When PR #1680 was merged to add the IdentifiedNode intermediate class, it was missing the required n3() fn, and missed the `__slots__` directive.
nicholascar
pushed a commit
that referenced
this pull request
Aug 1, 2024
* Fix missing features of IdentifiedNode When PR #1680 was merged to add the IdentifiedNode intermediate class, it was missing the required n3() fn, and missed the `__slots__` directive. * Remove type-abstract suppressions for IdentifiedNode usages because its no longer considered abstract by the type checker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1526
Proposed Changes
IdentifiedNodeto class hierarchy interm.py.IdentifiedNodesymbol from/rdflib/__init__.py.