DefinedNamespaceMeta.__getitem__ is slow

[anatoly-scherbakov]

Fixes #

Proposed Changes

• Cache the __getitem__ method to improve performance.

[aucampia]

Looks good to me, thanks for the PR.

[white-gecko]

Looks good to me, just a question, why not just use @cache, according to https://docs.python.org/3/library/functools.html#functools.cache it is the same as lru_cache(maxsize=None) and would be easier to read.

[aucampia]

Looks good to me, just a question, why not just use @cache, according to https://docs.python.org/3/library/functools.html#functools.cache it is the same as lru_cache(maxsize=None) and would be easier to read.

@cache would be better but it is only available from 3.9.

[aucampia]

Will merge this weekend if there is no further feedback.

[white-gecko]

Looks good to me, just a question, why not just use @cache, according to https://docs.python.org/3/library/functools.html#functools.cache it is the same as lru_cache(maxsize=None) and would be easier to read.

@cache would be better but it is only available from 3.9.

Thank you for the clarification. I think we can merge this now.