Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing "generate" option through in compute_qname_strict #1934

Merged
merged 1 commit into from
May 15, 2022

Conversation

mwatts15
Copy link
Contributor

@mwatts15 mwatts15 commented May 15, 2022

Summary of changes

Passes through an option in the compute_qname_strict interface so it raises an error in the same case as the "non-strict" version.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • For changes that have a potential impact on users of this project:
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
    • Considered adding an example in ./examples for new features.
    • Considered updating our changelog (CHANGELOG.md).
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

coveralls commented May 15, 2022

Coverage Status

Coverage remained the same at 88.267% when pulling 42950ab on mwatts15:master into d5eb957 on RDFLib:master.

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fix.

@aucampia aucampia requested a review from a team May 15, 2022 10:13
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label May 15, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@aucampia aucampia merged commit e5c8463 into RDFLib:master May 15, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants