Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: speed up flake8 by ignoring test data #1970

Merged
merged 1 commit into from
May 26, 2022

Conversation

aucampia
Copy link
Member

Summary of changes

flake8/flakeheaven is quite slow because it scans test data
directories also. This patch adds more directories to flake8 ignore so
that flake8/flakeheaven can run faster.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia marked this pull request as ready for review May 22, 2022 20:09
@aucampia aucampia requested a review from a team May 22, 2022 20:10
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label May 22, 2022
@coveralls
Copy link

coveralls commented May 22, 2022

Coverage Status

Coverage remained the same at 88.514% when pulling 91c54d0 on aucampia:iwana-20220522T2203-faster_flake8 into 958b9a1 on RDFLib:master.

flake8/flakeheaven is quite slow because it scans test data
directories also. This patch adds more directories to flake8 ignore so
that flake8/flakeheaven can run faster.
@aucampia aucampia force-pushed the iwana-20220522T2203-faster_flake8 branch from e306beb to 91c54d0 Compare May 25, 2022 18:22
@aucampia aucampia merged commit 9df5b21 into RDFLib:master May 26, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@aucampia aucampia deleted the iwana-20220522T2203-faster_flake8 branch June 4, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants