Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Literal.ill_formed to Literal.ill_typed #2003

Merged
merged 1 commit into from
Jul 9, 2022
Merged

Change Literal.ill_formed to Literal.ill_typed #2003

merged 1 commit into from
Jul 9, 2022

Conversation

ajnelson-nist
Copy link
Contributor

Summary of changes

This PR implements a rename decided on Issue 1960.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • (N/A) Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes. (Deferred to CI.)
  • For changes that have a potential impact on users of this project:
    • (N/A) Updated relevant documentation to avoid inaccuracies.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@ajnelson-nist
Change Literal.ill_formed to Literal.ill_typed
defb753 
This implements a rename decision on Issue 1960.

References:
* RDFLib#1960

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This was referenced Jun 30, 2022
Closed
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.224% when pulling defb753 on ajnelson-nist:issue-1960 into 8ccebc8 on RDFLib:master.

aucampia
aucampia approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aucampia
Copy link
Member

@ajnelson-nist thanks for this, a bit snowed under at work, will start release prep from the 8th, with a mind to release on the 15th.

ghost
ghost approved these changes Jun 30, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks for shepherding this one through.

@aucampia aucampia merged commit 9523d35 into RDFLib:master Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aucampia aucampia aucampia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajnelson-nist @coveralls @aucampia