feat: add type hints to rdflib.path
#2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
planning to merge without review as this has no runtime impact. |
There are some deprecation warnings coming from here as `evalPath` is used internally. I want to fix them, but I want type checking to ensure I don't mess up, so this just adds type checking, will fix the deprecation warnings in a seperate PR.
aucampia
force-pushed
the
iwana-20230311T1410-type_path
branch
from
fd472ef
to
73d2470
Compare
aucampia
added
review wanted
aucampia
changed the title
rdflib.pathrdflib.path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
There are some deprecation warnings coming from here as
evalPathis used internally. I want to fix them, but I want type checking to ensure I don't mess up, so this just adds type checking, will fix the deprecation warnings in a separate PR.This PR does not include any runtime changes, which can be confirmed from looking at the compact diff shared here.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.