Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posting a SPARQL command does not require urlencode #315

Merged
merged 4 commits into from
Nov 7, 2013

Conversation

kusamau
Copy link
Contributor

@kusamau kusamau commented Jul 26, 2013

This pull request is a fix for the issue #314

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling e024812 on kusamau:master into b6e6c5d on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 966b29e on kusamau:master into b6e6c5d on RDFLib:master.

@uholzer
Copy link
Contributor

uholzer commented Jul 26, 2013

Good. Let me make some comments:

  1. Make post postAsEncoded True by default in order to keep the current default behaviour.
  2. Add a comment about this to the documentation string of the class.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling b12c3d6 on kusamau:master into b6e6c5d on RDFLib:master.

@gromgull
Copy link
Member

Looks fine, there constants are defined twice though:

https://github.com/RDFLib/rdflib/pull/315/files#L0R17
and
https://github.com/RDFLib/rdflib/pull/315/files#L0R52

and there is something odd here:

https://github.com/RDFLib/rdflib/pull/315/files#L0R173

Tidy it up I'll hit merge! :)

  • Gunnar

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling 384a20f on kusamau:master into b6e6c5d on RDFLib:master.

gromgull added a commit that referenced this pull request Nov 7, 2013
Posting a SPARQL command does not require urlencode
@gromgull gromgull merged commit 5295ec5 into RDFLib:master Nov 7, 2013
@gromgull
Copy link
Member

gromgull commented Nov 7, 2013

Thanks! (apologies for the terrible ping)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants