-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition from 2to3 setup code to use of six.py as py2/3 compatibility layer #374
Conversation
do we still need ez_setup.py in the project dir? it won't work in py3 |
can we drop support for py3.2? |
See https://github.com/dbs/rdflib/tree/six_dbs for a number of additional commits on top of the "six" branch, which maintains 100% passing test coverage for Python 2.7 and brings the number of test failures down to 183 on Python 3.3. Note that I used r'strings' instead of ur'strings' for a few of these commits; seemed to work just fine. |
Pushed a bunch more commits onto https://github.com/dbs/rdflib/tree/six_dbs -- many of the unit tests were hidden behind earlier failures, which once those failures were fixed exposed more failures. Fun! Python 3.3 is currently running at 177 errors / 28 failures, while Python 2.7 is running at 7 errors / 3 failures (looks like a regression slipped into rdflib/term.py). All in all, I believe we're much closer to the goal. What is left looks pretty hairy, though :/ |
yupp, once i find a moment i'll continue this and make sure to pull your changes in. |
+1 - sounds like a good direction to me |
As a result from discussions in #373 we decided to try using six as a compatibility layer across python versions instead of on setup 2to3 conversion which might not work in certain environments.