Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a 'graphs' method to the Dataset object #504

Merged
merged 2 commits into from
Aug 2, 2015

Conversation

iherman
Copy link
Contributor

@iherman iherman commented Aug 1, 2015

This is to handle issue #495.

@gromgull
Copy link
Member

gromgull commented Aug 2, 2015

As far as I can recall it was removed intentionally, as the same functionality is available from the .contexts() method - inherited from the super-class. Let me check ...

@gromgull
Copy link
Member

gromgull commented Aug 2, 2015

Yep - removed and mentioned in the commit message here: 1ed4feb

I would vote we fix the docs instead.

@iherman
Copy link
Contributor Author

iherman commented Aug 2, 2015

Well... I respectfully disagree. The very reason for having the Dataset object is because, if one uses RDFLib in terms of the RDF 1.1 standard, then the notion of "context" is unknown, whereas the term dataset and graph is defined and used all over the place. In this sense, from a usability point of view, the function name graphs() is clear, whereas the term contexts() is not.

I do not remember the history of this, it has been a very long time ago when this was done. It may well be that, originally, I actually used the method name graphs() and somebody changed to contexts() without me paying attention. That was my mistake then (I have to admit that I did not really look at rdflib in the past few years, my work focus at W3C have radically changed lately).

I am not sure what the decision process is in this case, and I do not want to make a big fuss about this; not being very active any more I do not think it is my place to do so. I just want to express my strong disagreement...

@gromgull
Copy link
Member

gromgull commented Aug 2, 2015

decision process is a big word for what happens in RDFLib :)

Like you, I am not really using rdflib much myself anymore, and you make a fair point. I have no problem with reintroducing the method as an alias for contexts, it should then probably just do return self.contexts() though, and not duplicate the code.

@joernhees joernhees added enhancement New feature or request in-resolution labels Aug 2, 2015
@joernhees joernhees added this to the rdflib 4.2.1 milestone Aug 2, 2015
joernhees added a commit that referenced this pull request Aug 2, 2015
Re-added 'graphs' method as alias of 'contexts' to the Dataset object, fixes #495
@joernhees joernhees merged commit fbc29da into master Aug 2, 2015
@joernhees joernhees deleted the issue-495-graphs-method branch August 2, 2015 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants