Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logger output #662

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Remove logger output #662

merged 1 commit into from
Oct 26, 2016

Conversation

david4096
Copy link
Contributor

Considering the version is accessible on the module, we would like to remove this logging.

@coveralls
Copy link

coveralls commented Oct 25, 2016

Coverage Status

Coverage increased (+0.002%) to 62.833% when pulling 12e0b34 on david4096:master into 11e835a on RDFLib:master.

@david4096
Copy link
Contributor Author

Hey, I got a +1, thanks! Anything I might need to do to get this very minor change merged?

@gromgull gromgull merged commit 1826f17 into RDFLib:master Oct 26, 2016
@joernhees joernhees added this to the rdflib 4.2.2 milestone Nov 9, 2016
@joernhees
Copy link
Member

:( i somehow liked the output, especially in interactive sessions as it saved me tons of times already... maybe it's a bit too close to an rdflib dev workflow though...

see #413

@joernhees
Copy link
Member

ok, so i thought about this again: i agree that always putting that message there might be annoying for some people, but in interactive sessions i have the feeling that it in the end helps us a lot to make version info very easily accessible to non rdflib experts. More people will realize if they have an old version, and they might even just write it into bug reports here.

So what i'll do (see 4bb4362):

  • in interactive sessions i weigh the advantages higher than the minor annoyance of people. I'll make the check harder (it will also check if stdout is a tty, if not no INFO message)
  • in productive code i weigh the advantage lower than the bigger annoyance of people who can't correctly configure python standard logging. That's why i'll make it a debug statement in those cases (they're hidden by default, unless you say you want debug output... if you want that, you'll get a version number)

Please open another issue in case that's not ok for you...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants