Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Nones with is or is not #964

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Conversation

kinow
Copy link
Contributor

@kinow kinow commented Mar 7, 2020

Using is and is not instead of == and != for None comparisons - https://realpython.com/python-is-identity-vs-equality/

I think normally we don't want to use the == and !=? Not sure if it will pass Travis checks.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.624% when pulling bb0a487 on kinow:compare-nones into 7aa2df6 on RDFLib:master.

@nicholascar nicholascar merged commit 39d25fa into RDFLib:master Mar 9, 2020
@white-gecko white-gecko added this to the rdflib 5.0.0 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants