Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 920 fixes as per Issue desc + test #974

Merged
merged 1 commit into from Mar 16, 2020
Merged

Issue 920 fixes as per Issue desc + test #974

merged 1 commit into from Mar 16, 2020

Conversation

nicholascar
Copy link
Member

Single char fix identified in Issue! Included test

@nicholascar nicholascar added this to the rdflib 5.0.0 milestone Mar 16, 2020
@nicholascar nicholascar changed the title Issue 920 fixes as per Issue desc, + test Issue 920 fixes as per Issue desc + test Mar 16, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.756% when pulling 074adcc on nicholascar:Issue-920-redux into 41021d9 on RDFLib:master.

Copy link
Member

@white-gecko white-gecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to RFC3987 (IRI) this should be fine in the case of ipath-empty.

   IRI            = scheme ":" ihier-part [ "?" iquery ]
                         [ "#" ifragment ]

   ihier-part     = "//" iauthority ipath-abempty
                  / ipath-absolute
                  / ipath-rootless
                  / ipath-empty

   ipath-empty    = 0<ipchar>

@white-gecko white-gecko merged commit 107ffb6 into RDFLib:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants