-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a long-term solution for keepalive #51
Comments
Long term solution is Requests |
Requests is compatible with 2.6+. So, it means that refactoring 1.x will lead to the loss of compatibility with 2.5 (I don't remember is 2.4 is supported) |
oh… I just noticed, that you only use 2.7+ in Continuous Integration since 6 days ago. If that's the plan, then we can definitely use Requests for emulating current network interface |
@indeyets honestly I'd prefer to switch to |
According to henrysher/urlgrabber#2 does not look that |
Using this port http://pastie.org/2388246 could be an option, but I think the author (@bgw) has not published any package with it, or at least I can't find it. |
it's only ~300 lines of code - just add it to SPARQLWrapper directly ? On 3 November 2015 at 08:29, Sergio Fernández notifications@github.com
|
@gromgull LGPL license |
I'd personally remove the keep alive support until we do the major refactoring for 2.x; opinions on that? |
Solved by using a new keepalive package (required by license terms). |
I don't have deep insight into how SparqlWrapper is being used in applications, but I wonder if mechanisms like these should be pluggable and interchangeable? By which I mean that SparqlWrapper (and thus RDFLib) shouldn't bundle a lot of choices by default, but support opt-ins by using a pluggable API. It could even provide sensible defaults for "advanced" behaviour by doing try-imports and declaring optional dependencies. (But avoid opinionated choices.) Or perhaps better, work as a component in an application responsible for optimizing its HTTP handling (and choice of e.g. keep-alive, HTTP/2...). |
As reported in the mailing list, looks like the
keepalive
module has been removed in version 3.9.1 ofurlgrabber
.I found some discussions about the issue:
But I need to read more to find a long-term solution for such feature...
The text was updated successfully, but these errors were encountered: