Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/memo export #127

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Feature/memo export #127

merged 10 commits into from
Jan 9, 2024

Conversation

skvrnami
Copy link
Contributor

@skvrnami skvrnami commented Dec 31, 2023 •
edited
Loading

Changes:

  • closes memos export #123
  • refactor of export codebook so that it the exported file is generated after clicking the button (not after every change of codebook, categories and links between them)

some things to consider:

  • when exporting memo (and codebook), I do not put timestamp into the filename (because it causes error when testing due to different snapshot filenames). I think it is ok, user is warned when the same file exists and export would be overwritten and can change the filename.

@skvrnami skvrnami marked this pull request as ready for review January 1, 2024 10:53
@skvrnami skvrnami requested a review from hlageek January 1, 2024 10:53
@hlageek
Copy link
Contributor

hlageek commented Jan 9, 2024

Minor tweaks suggested:

  • change separator in categories export
  • include memo title in export
    Nice refactor. Can be merged.

@skvrnami skvrnami merged commit 773fb16 into main Jan 9, 2024
3 checks passed
@skvrnami skvrnami deleted the feature/memo-export branch January 9, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlageek hlageek Awaiting requested review from hlageek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memos export
2 participants
@skvrnami @hlageek