-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable gate extension logic for the latest flowJo wsp #106
Comments
To investigate this behavior from the relative recent flowJo 10.6.1, The gates seems to be fine without extension(by relaxing the So we may conclude the legacy behavior has been fixed(i.e. gate original coordinates are always preserved by xml) by the newer flowJo so that we no longer need to do this hack. For now, I will set default |
The existing gate extension rationale was detailed in RGLab/flowWorkspace#36, basically it is a heuristic fix for the issue of truncated gate coordinates recorded in flowJo xml workspace. i.e. whenever the negative gate coordinates observed from xml, it's an indication that the gate is meant to extend the far lower end to cover the rest of negative data area.
However, we started to experience some problems where the gate coordinate extension shouldn't be triggered.
e.g.
The exception will be thrown (RGLab/flowWorkspace#334) when attempting to extend
ellipsoidGate
, which appears to be unnecessary becauseellipsoidGate
is internally interpolated into polygon thus the coordinates are computed from antipodal points from xml and probably won't have the same truncation issue as the other polygonGates.So we may want to skip extension for
ellipsoidGate
.But the default gate extension behavior won't be even safe for
polygonGate
. e.g.This is what the original gate looks like
And the gate coordinates do contain negative values
And the default
extend_value=0
threshold will trigger the extension logic, which distorted the original gate and its stats, e.g.The text was updated successfully, but these errors were encountered: