Skip to content

gh-actions/test-on-iotlab: install riotctrl #16118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

gh-actions/test-on-iotlab: install riotctrl #16118

merged 1 commit into from
Mar 2, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 2, 2021 •
edited
Loading

Contribution description

For actually running the test, the docker container is not used. As such, riotctrl needs to be installed for the tests to succeed.

Testing procedure

I started a test run over at my fork. tests/congure_test should now pass (or at least not fail on import due to a missing riotctrl ;-)).

Issues/PRs references

None

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: CI Area: Continuous Integration of RIOT components CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Mar 2, 2021
@miri64 miri64 added this to the Release 2021.04 milestone Mar 2, 2021
@miri64 miri64 requested review from aabadie and fjmolinas March 2, 2021 08:16
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 2, 2021
@miri64
gh-actions/test-on-iotlab: install riotctrl
9e91170 
For actually running the test, the docker container is not used. As
such, `riotctrl` needs to be installed for the tests to succeed.
@miri64 miri64 force-pushed the gh-actions/fix/test-on-iotlab-riotctrl branch from 50cadb4 to 9e91170 Compare March 2, 2021 08:35
@miri64
Copy link
Member Author

miri64 commented Mar 2, 2021

For the two b- nodes there still seems to be an issue with the congure_test test, but that seems unrelated to this fix (it's an integer conversion error within the test). Will investigate in a separate PR.

kaspar030
kaspar030 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Trusting @miri64 testing.

@maribu maribu merged commit e5c33f6 into RIOT-OS:master Mar 2, 2021
@miri64 miri64 mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2021.04
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @kaspar030 @maribu